Myracle commented on code in PR #27577:
URL: https://github.com/apache/flink/pull/27577#discussion_r4478568148
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/RegexpInputTypeStrategy.java:
##########
@@ -57,10 +57,14 @@ public ArgumentCount getArgumentCount() {
@Override
public Optional<List<DataType>> inferInputTypes(
final CallContext callContext, final boolean throwOnFailure) {
- if (STRING_ARG.inferArgumentType(callContext, ARG_STR,
throwOnFailure).isEmpty()) {
+ final Optional<DataType> strType =
Review Comment:
Changed`REGEXP_SPLIT` to use a generic string argument sequence, like`SPLIT`
, and reverted the changes to the shared`REGEXP` strategy. Invalid regex
literals now return NULL as documented; I updated the result nullability and
integration cases accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
