snuyanzin commented on code in PR #29628:
URL: https://github.com/apache/flink/pull/29628#discussion_r4480819322
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/SqlJsonUtils.java:
##########
@@ -596,9 +598,9 @@ public static String jsonType(
final Object value;
try {
- // PathNotFoundException extends InvalidPathException (covers both
exceptions)
value = JsonPath.parse(parsedInput.obj,
JSON_PATH_TYPE_CONFIG).read(path);
- } catch (InvalidPathException e) {
+ } catch (JsonPathException e) {
+ // Same cases as in jsonLength: a missing or invalid path, or a
failing path function.
Review Comment:
let's not refer in comments to other methods this way
otherwise could be easily forgotten while refactoring
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
