[
https://issues.apache.org/jira/browse/FLINK-5635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859201#comment-15859201
]
ASF GitHub Bot commented on FLINK-5635:
---------------------------------------
Github user ex00 commented on a diff in the pull request:
https://github.com/apache/flink/pull/3205#discussion_r100252102
--- Diff: flink-contrib/docker-flink/docker-compose.yml ---
@@ -16,21 +16,22 @@
# limitations under the License.
################################################################################
-version: "2"
+# Set the FLINK_DOCKER_IMAGE_NAME environment variable to override the
image name to use
+
+version: "2.1"
services:
jobmanager:
- image: flink
- container_name: "jobmanager"
+ image: ${FLINK_DOCKER_IMAGE_NAME:-flink}
expose:
- "6123"
--- End diff --
the variable in yml doesn't depends variable from Dockerfile.
see https://docs.docker.com/compose/compose-file/#variable-substitution
> Improve Docker tooling to make it easier to build images and launch Flink via
> Docker tools
> ------------------------------------------------------------------------------------------
>
> Key: FLINK-5635
> URL: https://issues.apache.org/jira/browse/FLINK-5635
> Project: Flink
> Issue Type: Improvement
> Components: Docker
> Affects Versions: 1.2.0
> Reporter: Jamie Grier
> Assignee: Jamie Grier
>
> This is a bit of a catch-all ticket for general improvements to the Flink on
> Docker experience.
> Things to improve:
> - Make it possible to build a Docker image from your own flink-dist
> directory as well as official releases.
> - Make it possible to override the image name so a user can more easily
> publish these images to their Docker repository
> - Provide scripts that show how to properly run on Docker Swarm or similar
> environments with overlay networking (Kubernetes) without using host
> networking.
> - Log to stdout rather than to files.
> - Work properly with docker-compose for local deployment as well as
> production deployments (Swarm/k8s)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
