MartijnVisser opened a new pull request, #29819:
URL: https://github.com/apache/flink/pull/29819

   ## What is the purpose of the change
   
   Supersedes #26102 by @cnauroth, which was approved but closed as stale after 
going out of date with master. It runs the common flink-hadoop-fs integration 
test suites against GCS, so the RecoverableWriter behind `FileSink` and 
checkpoints on `gs://` gets the same coverage as S3 and OSS.
   
   ## Brief change log
   
     - The first commit is #26102 unchanged apart from the ArchUnit store 
conflict, with Chris as the author.
     - The second commit moves the tests to `GSTestCredentials` 
(`IT_CASE_GCS_BUCKET`) from #28286, drops `RequireGCSConfiguration` and the 
duplicate behavior suite, removes a duplicate `flink-core` test-jar entry and 
adds the missing `@Test` on the two disabled overrides.
     - `AbstractHadoopRecoverableWriter(Exception)ITCase` accept a null 
`getLocalTmpDir()`. S3 and OSS return a directory, so they behave as before.
   
   ## Verifying this change
   
   The GCS ITCases skip unless `IT_CASE_GCS_BUCKET` is set, so CI only compiles 
them. I ran them locally on e08a17a9c81 against a private bucket with user 
application-default credentials: 35 executed, 4 skipped, 0 failed. Keeping only 
the last persisted component on recover fails 
`testRecoverAfterMultiplePersistsState` and its multipart variant, while the 
existing `GSRecoverableWriterITCase` stays green.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to