MartijnVisser commented on code in PR #29832:
URL: https://github.com/apache/flink/pull/29832#discussion_r4514035578


##########
pom.xml:
##########
@@ -1219,8 +1219,6 @@ under the License.
 
                        <properties>
                                
<surefire.excludedGroups.jdk>org.apache.flink.testutils.junit.FailsOnJava25,</surefire.excludedGroups.jdk>
-                               <!-- Minimum Hadoop version working with jdk 25 
according to https://issues.apache.org/jira/browse/HADOOP-19212 -->
-                               
<flink.hadoop.version>3.4.3</flink.hadoop.version>

Review Comment:
   The profile override never enforced it either, 
`-Dflink.hadoop.version=2.10.2` was still accepted on JDK 25. Added a 
`requireProperty` rule for 3.4.3 and later.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to