[ 
https://issues.apache.org/jira/browse/FLINK-5728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15859440#comment-15859440
 ] 

Robert Metzger commented on FLINK-5728:
---------------------------------------

+1 for enabling it by default.

I'm against removing the methods completely. By having reasonable default 
settings (providing at least once guarantees when checkpointing is enabled) we 
have 99% of our users happy. Those who have complicated setups (checkpointing 
enabled, but no at least once in the producer) can still configure if needed.
I don't like dictating one possible setting to our users, if we can easily 
provide them with ways to change the behavior. (Just imagine a company who's 
struggling with achieving good checkpointing performance, and they find out its 
the Kafka producer. If we don't provide them with an option, we'll have to add 
the flag again)

I'm open to discuss this. If we have a majority of people with good arguments 
for removing those methods, I'll agree to it as well.


> FlinkKafkaProducer should flush on checkpoint by default
> --------------------------------------------------------
>
>                 Key: FLINK-5728
>                 URL: https://issues.apache.org/jira/browse/FLINK-5728
>             Project: Flink
>          Issue Type: Improvement
>          Components: Kafka Connector
>            Reporter: Tzu-Li (Gordon) Tai
>
> As discussed in FLINK-5702, it might be a good idea to let the 
> FlinkKafkaProducer flush on checkpoints by default. Currently, it is disabled 
> by default.
> It's a very simple change, but we should think about whether or not we want 
> to break user behaviour, or have proper usage migration.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to