ShawnGarello opened a new pull request, #29840:
URL: https://github.com/apache/flink/pull/29840

   ## What is the purpose of the change
   
   `FileSinkAvroWritersTests.test_avro_basic_write` failed on the release-2.3 
nightly 
([CI](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=80684&view=logs&j=9cada3cb-c1d3-5621-16da-0f718fb86602)).
 The test ran across 05:00 UTC (04:59:35–05:00:10 in the log), so the sink's 
default hourly `DateTimeBucketAssigner` could put the two records in two 
directories, and the unsorted `glob` read the later one first. This makes the 
test sink write to the base path, so both records land in one file.
   
   
   ## Brief change log
   
     - `FileSinkAvroWritersTests` builds its `FileSink` with 
`BucketAssigner.base_path_bucket_assigner()`.
     - `_read_avro_file` reads the part files directly under the output 
directory.
   
   
   ## Verifying this change
   
   This change is already covered by existing tests, such as 
`FileSinkAvroWritersTests` in `pyflink/datastream/formats/tests/test_avro.py`.
   
   I also reproduced the CI failure locally with a throwaway harness 
(per-millisecond buckets, a short sleep between the records, reverse-sorted 
`glob`). It failed with the same `AssertionError: False != True` before this 
change and passes after it.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code 2.1.319 (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to