fresh-borzoni commented on PR #29653: URL: https://github.com/apache/flink/pull/29653#issuecomment-6755812742
@gustavodemorais thanks, reworked as suggested 👍 Some clarifications and additions: 1. partialDeleteKeys also evaluates columns equal to a key column. Predicates hold on full rows, but a delete by key carries only key columns, so an aligned pk column could be null. 2. Aligned keys are added instead of replacing, otherwise a key passed through a cast is lost. 3. No outer joins: Calcite pulls up nothing from their conditions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
