raminqaf commented on code in PR #29674:
URL: https://github.com/apache/flink/pull/29674#discussion_r4525849035
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/operations/SqlNodeToOperationSqlCreateOrAlterMaterializedTableConverterTest.java:
##########
@@ -654,26 +651,26 @@ void
testCreateOrAlterMaterializedTableWithChangedStartMode(
private static Collection<Arguments> startModeAlterCases() {
return List.of(
+ Arguments.of("RESUME_OR_FROM_BEGINNING",
StartMode.resumeOrFromBeginning()),
Review Comment:
You have updated these test to use the new API. IMO we can keep the old
tests to ensure that the old API `of(...)` works.
If you want to change there are some other classes that use the old API:
- `ShowCreateUtilTest`
- `TestFileSystemCatalogTest`
- `AlterMaterializedTableChangeOperationValidationTest`
etc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
