gaborgsomogyi commented on code in PR #29874:
URL: https://github.com/apache/flink/pull/29874#discussion_r4537629733
##########
flink-runtime/src/main/java/org/apache/flink/runtime/security/SecurityConfiguration.java:
##########
@@ -173,4 +203,25 @@ private static List<String> parseList(String value) {
return Arrays.asList(value.trim().replaceAll("(\\s*,+\\s*)+",
",").split(","));
}
+
+ private static Map<String, String>
extractSecurityRelevantConfig(Configuration flinkConfig) {
+ final Map<String, String> result = new HashMap<>();
+ for (Map.Entry<String, String> entry : flinkConfig.toMap().entrySet())
{
+ if (isSecurityRelevantConfigKey(entry.getKey())) {
+ result.put(entry.getKey(), entry.getValue());
+ }
+ }
+ return result;
+ }
+
+ private static boolean isSecurityRelevantConfigKey(String key) {
+ // Keep this in sync with the options consumed by the bundled security
modules:
+ // JaasModule (security.*, io.tmp.dirs), ZookeeperModule
(zookeeper.sasl.*) and
+ // HadoopModule (flink.hadoop.*, fs.hdfs.*).
+ return key.startsWith("security.")
+ || key.startsWith("zookeeper.sasl.")
+ || key.startsWith("flink.hadoop.")
+ || key.startsWith("fs.hdfs.")
+ || key.equals(CoreOptions.TMP_DIRS.key());
+ }
Review Comment:
I think this is just wrong direction no matter what
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
