Dennis-Mircea opened a new pull request, #1256:
URL: https://github.com/apache/flink-kubernetes-operator/pull/1256

   ## What is the purpose of the change
   
   Since the JOSDK 5 upgrade (1.13.0) the operator shaded jar bundles 2 fabric8 
HTTP client factories (which can be checked with `mvn dependency:tree`): the 
JDK one JOSDK ships and the OkHttp one the operator selects. fabric8 picks the 
first one listed, the JDK client, which sends no WebSocket pings, so a lost API 
server connection stays undetected for minutes while the health probe reports 
healthy.
   
   ## Brief change log
   
     - Root pom: `kubernetes-client` excludes only 
`kubernetes-httpclient-vertx`, the client fabric8 ships; the stale OkHttp 
exclusions, the `depend-on-okhttp4` profile and `okhttp.version` are gone.
     - Operator pom: `operator-framework` excludes only 
`kubernetes-httpclient-jdk`, the client JOSDK ships, and the stale 
`kubernetes-httpclient-okhttp` exclusion and the `okhttp` exclusion on the 
selected client are gone (same in the api pom). Surefire now passes 
`fabric8.httpclient.impl` to the tests for better stability.
     - `KubernetesClientUtils` and `FlinkOperatorWebhook` log the HTTP client 
implementation at startup.
     - NOTICE files of the operator and the standalone autoscaler match what 
the shaded jars bundle.
     - Docs: the IPv6 `KUBERNETES_DISABLE_HOSTNAME_VERIFICATION` workaround 
(FLINK-32777) is removed, OkHttp 4+ canonicalizes IP addresses in hostname 
verification.
   
   
   ## Verifying this change
   This change can be verified through the newly added UT + manually within 
Minikube.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): yes
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: 
no
     - Core observer or reconciler logic that is regularly executed: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change the checkbox below to `[X]` followed by the name of the tool, and 
uncomment the
   "Generated-by" line. See the ASF Generative Tooling Guidance for details:
   https://www.apache.org/legal/generative-tooling.html
   
   You are responsible for the quality and correctness of every change in this 
PR
   regardless of the tooling used. Low-effort AI-generated PRs will be closed. 
See
   AGENTS.md for the full guidance.
   -->
   
   - [ ] Yes (please specify the tool below)
   
   <!--
   Generated-by: [Tool Name and Version]
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to