1996fanrui opened a new pull request, #29900:
URL: https://github.com/apache/flink/pull/29900

   ## What is the purpose of the change
   
   The `apache-flink` Python package (sdist and wheels) has shipped without a 
NOTICE file since 1.13: `flink-python/MANIFEST.in` contains `include NOTICE`, 
but no `flink-python/NOTICE` exists and `setup.py` only copies `LICENSE`.
   
   Apache Trusted Releases (ATR) checks on the 1.20.6 rc1 candidate reported 
exactly one BLOCKER for this: check `license.files`, "No NOTICE file found" for 
`apache_flink-1.20.6.tar.gz`. The `apache_flink_libraries` sdist and the source 
tgz passed.
   
   The ASF release policy requires a NOTICE file in every distributed artifact: 
https://www.apache.org/legal/release-policy.html#licensing-documentation
   
   ## Brief change log
   
     - Add `flink-python/NOTICE` with the standard ASF header, identical to the 
header of the root `NOTICE`. The existing `include NOTICE` in `MANIFEST.in` 
picks it up.
   
   ## Verifying this change
   
   This change is a trivial rework without any test coverage. Manually verified 
by building the sdist from `flink-python` (`python setup.py sdist` with 
setuptools 75.x):
   
     - With this change: `apache_flink-2.5.dev0.tar.gz` contains 
`apache_flink-2.5.dev0/NOTICE` at its root, with the expected content.
     - Without this change: setuptools prints `warning: no files found matching 
'NOTICE'` and the sdist has no NOTICE.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to