1fanwang commented on code in PR #29286:
URL: https://github.com/apache/flink/pull/29286#discussion_r4559480253


##########
flink-python/pyflink/fn_execution/datastream/embedded/operations.py:
##########
@@ -211,7 +213,8 @@ def on_timer_func(timestamp):
             yield from process_func(on_timer(timestamp, timer_context))
 
         return TwoInputOperation(
-            open_func, close_func, process_element_func1, 
process_element_func2, on_timer_func)
+            open_func, close_func, process_element_func1, 
process_element_func2,
+            on_timer_func if on_timer else None)

Review Comment:
   Done in 
https://github.com/apache/flink/commit/632b8dd1a42bdc0eaeedeb3f1afcbc2f8cc9acc9.
 The missing callback is handled inside on_timer_func now, and the return 
statement is back to master's form.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to