dianfu commented on code in PR #29297:
URL: https://github.com/apache/flink/pull/29297#discussion_r4560168152
##########
flink-python/pyflink/table/types.py:
##########
@@ -2348,25 +2351,33 @@ def to_arrow_type(data_type: DataType, *,
allow_nested=False):
else:
return pa.timestamp('ns')
elif isinstance(data_type, MapType):
- key_type = to_arrow_type(data_type.key_type, allow_nested=allow_nested)
- value_type = to_arrow_type(data_type.value_type,
allow_nested=allow_nested)
+ key_type = to_arrow_type(data_type.key_type, allow_nested=allow_nested,
+ allow_nested_rows=allow_nested_rows)
+ value_type = to_arrow_type(data_type.value_type,
allow_nested=allow_nested,
+ allow_nested_rows=allow_nested_rows)
# PyArrow 5 only accepts data types and always makes map values
nullable.
if hasattr(pa.MapType, 'item_field'):
value_type = pa.field("value", value_type,
nullable=data_type.value_type._nullable)
return pa.map_(key_type, value_type)
elif isinstance(data_type, ArrayType):
Review Comment:
The current implementation makes sense to me. Have created a separate ticket
for the zoned timestamp issue: https://issues.apache.org/jira/browse/FLINK-41484
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
