MartijnVisser opened a new pull request, #29932:
URL: https://github.com/apache/flink/pull/29932
## What is the purpose of the change
* `PreValidateReWriter` rewrites the source of an `INSERT INTO` with a
column list or static partitions as SQL before validation, which is what broke
in FLINK-40694. This applies them as a projection on the converted plan
instead, as FLINK-40039 did for CTAS and RTAS.
## Brief change log
* `PartialInsertUtil` adds the projection, `PreValidateReWriter` only
validates, now with the planner's validator, and `SqlRewriterUtils` is removed
* An `ORDER BY` ordinal refers to the query's select list instead of the
sink's column order, unlisted STRUCTURED and RAW columns are padded with NULL
instead of failing, and a static partition column in the column list reports a
duplicate target column
* Operators below the projection see the query's column order instead of the
sink's, so plans of partial inserts change. The Jira ticket has a release note.
## Verifying this change
This change added tests and can be verified as follows:
* New `PartialInsertTest` cases for the `ORDER BY` ordinal, STRUCTURED and
RAW padding, a static partition column in the column list and an invalid static
partition value, the first three fail on master (the ordinal case in batch mode)
* Updated plans in the planner tests, the explain tests and `table.q`
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
---
##### Was generative AI tooling used to co-author this PR?
- [X] Yes (please specify the tool below)
Generated-by: Claude Code (Claude Opus 5, Claude Opus 5.5)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]