jubins opened a new pull request, #29944:
URL: https://github.com/apache/flink/pull/29944

   ## What is the purpose of the change
   
   Adds direct unit tests for `IntArrayList`, `LongArrayList` and 
`BooleanArrayList` in `org.apache.flink.runtime.util`. These classes implement 
their own array growth, `removeLast`/`removeLong` shifting and an immutable 
`IntArrayList.EMPTY`, and until now were only exercised indirectly. This is a 
test-only change; no production code is modified.
   
   Fixes [FLINK-41501](https://issues.apache.org/jira/browse/FLINK-41501).
   
   ## Brief change log
   
     - `IntArrayListTest`: growth from initial capacity 0 and 1 with order 
preserved, `toArray` returns a copy, `removeLast` order and 
`NoSuchElementException` on empty, clear and reuse, `EMPTY` throws 
`UnsupportedOperationException` on `add`/`removeLast`.
     - `LongArrayListTest`: growth from capacity 0 and 1, `toArray` copy, 
`removeLong` from the middle (shift), first and last element, 
`IndexOutOfBoundsException` for `index == size`, clear and reuse, 
`getInternalArray` aliasing the backing array.
     - `BooleanArrayListTest`: growth from capacity 0 and 1, `toArray` copy, 
`isEmpty`/`size`, clear and reuse.
   
   ## Verifying this change
   
   Please make sure both new and modified tests in this PR follow [the 
conventions for tests defined in our code quality 
guide](https://flink.apache.org/how-to-contribute/code-style-and-quality-common/#7-testing).
   
   This change added tests and can be verified as follows:
   
     - Added `IntArrayListTest` (7 test cases), `LongArrayListTest` (8) and 
`BooleanArrayListTest` (4); run with `./mvnw -pl flink-runtime test 
-Dtest=IntArrayListTest,LongArrayListTest,BooleanArrayListTest`.
     - Checked that the tests detect regressions: temporarily removing the 
`System.arraycopy` in `IntArrayList#grow` and in `LongArrayList#removeLong` 
made 5 test cases fail; the production files were then restored.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to