Copilot commented on code in PR #29958:
URL: https://github.com/apache/flink/pull/29958#discussion_r4579659174


##########
flink-runtime-web/web-dashboard/src/app/pages/job/overview/job-overview.component.html:
##########
@@ -17,11 +17,23 @@
   -->
 
 <nz-alert
-  *ngIf="nodes.length === 0"
+  *ngIf="nodes.length === 0 && !jobFailed"
   nzShowIcon
   nzType="info"
   nzMessage="Job is not running yet."
 ></nz-alert>
+<nz-alert
+  *ngIf="nodes.length === 0 && jobFailed"
+  nzShowIcon
+  nzType="error"
+  nzMessage="Job failed"
+  [nzDescription]="jobFailedDescription"
+></nz-alert>
+<ng-template #jobFailedDescription>
+  There are no tasks to show. The
+  <a routerLink="../exceptions">Exceptions</a>

Review Comment:
   The new spec does not exercise this link: its component override removes 
`RouterLink`, and it only checks text content, so a missing or incorrect 
navigation target would still pass. Please retain `RouterLink` in a 
router-enabled test setup and assert that clicking Exceptions navigates to the 
current job’s sibling `exceptions` route.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to