snuyanzin opened a new pull request, #29971:
URL: https://github.com/apache/flink/pull/29971

   ## What is the purpose of the change
   
   The PR to make deepCopy false in case of Calc
   
   ## Brief change log
   
   codegen
   ## Verifying this change
   
   extra tests checking for edge cases
   
   also measure via benchmark (could be done with any calc), I did with simple 
`LOWER` function
   before
   ```
   Benchmark                      (ascii)  (inputLength)   Mode  Cnt     Score  
   Error   Units
   SqlLowerBenchmark.lower           true             10  thrpt    5  7084.180 
± 356.264  ops/ms
   SqlLowerBenchmark.lower           true            100  thrpt    5  4260.965 
± 139.482  ops/ms
   SqlLowerBenchmark.lower           true           1000  thrpt    5   835.992 
±  11.232  ops/ms
   SqlLowerBenchmark.lower           true          10000  thrpt    5    83.044 
±   3.874  ops/ms
   SqlLowerBenchmark.lower          false             10  thrpt    5  6472.497 
± 400.783  ops/ms
   SqlLowerBenchmark.lower          false            100  thrpt    5  2664.675 
± 171.561  ops/ms
   SqlLowerBenchmark.lower          false           1000  thrpt    5   341.138 
±   2.143  ops/ms
   SqlLowerBenchmark.lower          false          10000  thrpt    5    44.363 
±   0.394  ops/ms
   ```
   
   after
   ```
   Benchmark                      (ascii)  (inputLength)   Mode  Cnt     Score  
   Error   Units
   SqlLowerBenchmark.lower           true             10  thrpt    5  9635.009 
± 525.027  ops/ms
   SqlLowerBenchmark.lower           true            100  thrpt    5  5162.393 
± 160.243  ops/ms
   SqlLowerBenchmark.lower           true           1000  thrpt    5   929.245 
±  13.896  ops/ms
   SqlLowerBenchmark.lower           true          10000  thrpt    5    97.148 
±   0.415  ops/ms
   SqlLowerBenchmark.lower          false             10  thrpt    5  9446.584 
± 802.926  ops/ms
   SqlLowerBenchmark.lower          false            100  thrpt    5  4881.184 
± 188.646  ops/ms
   SqlLowerBenchmark.lower          false           1000  thrpt    5   838.747 
±  19.123  ops/ms
   SqlLowerBenchmark.lower          false          10000  thrpt    5    87.712 
±   0.184  ops/ms
   ```
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (yes)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     - If yes, how is the feature documented? (not applicable)
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change the checkbox below to `[X]` and replace the placeholder in the 
"Generated-by"
   line with the tool name and version. Otherwise remove the "Generated-by" 
line.
   See the ASF Generative Tooling Guidance for details:
   https://www.apache.org/legal/generative-tooling.html
   
   You are responsible for the quality and correctness of every change in this 
PR
   regardless of the tooling used. Low-effort AI-generated PRs will be closed. 
See
   AGENTS.md for the full guidance.
   -->
   
   - [ ] Yes (please specify the tool below)
   
   Generated-by: [Tool Name and Version]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to