Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/3278
@tillrohrmann I've hopefully addressed your comments. Could you please have
a look?
The major change was to refactor the `DummyFlinkKafkaProducer` so that a
simple mock `KafkaProducer` can be provided for tests where a simple
`verify(mockProducer).send(...)` is sufficient. The refactored version also has
the advantage that it makes sure the `Callback` implementation in the connector
is correct (correctly decrements `pendingRecords` value).
Note: the only thing I could not really improve is the
`testAtLeastOnceProducer` test. Like before, the refactored version is still
essentially continuously checking whether the snapshot method has returned
early. The test is definitely stable, just that I don't think there is a better
approach for it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
