gustavodemorais opened a new pull request, #29975:
URL: https://github.com/apache/flink/pull/29975

   ## What is the purpose of the change
   
   Since FLINK-41371, row-semantic PTFs with insert-only output consume upsert 
inputs directly. For an upsert source with full deletes, the planner still kept 
a ChangelogNormalize below the PTF that emits the same changelog it receives. 
The delete-kind inference accepted the ChangelogNormalize's full-delete answer 
to a delete-by-key request without checking it, so the fallback that removes 
the normalize never ran.
   
   ## Brief change log
   
   - Add `visitChild` that only accepts a child providing exactly the required 
delete kind, and use it in `visitChildren` and for the delete-by-key request of 
PTF table arguments
   
   ## Verifying this change
   
   - `ProcessTableFunctionTest#testUpsertInputWithRowSemanticsAndFullDeletes`
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): no
   - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
   - The serializers: no
   - The runtime per-record code paths (performance sensitive): no
   - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
   - The S3 file system connector: no
   
   ## Documentation
   
   - Does this pull request introduce a new feature? no
   - If yes, how is the feature documented? (not applicable)
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes (please specify the tool below)
   
   2.1.304 (Claude Code) with Opus 5.5
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to