snuyanzin commented on code in PR #29967:
URL: https://github.com/apache/flink/pull/29967#discussion_r4589052230
##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-process-table-function_1/deduplicate-first-arrival-restore/plan/deduplicate-first-arrival-restore.json:
##########
@@ -0,0 +1,160 @@
+{
+ "flinkVersion" : "2.5",
+ "nodes" : [ {
+ "id" : 5,
+ "type" : "stream-exec-table-source-scan_2",
+ "scanTableSource" : {
+ "table" : {
+ "identifier" : "`default_catalog`.`default_database`.`payments`",
+ "resolvedTable" : {
+ "schema" : {
+ "columns" : [ {
+ "name" : "payment_id",
+ "dataType" : "VARCHAR(2147483647)"
+ }, {
+ "name" : "amount",
+ "dataType" : "INT"
+ } ]
+ }
+ }
+ }
+ },
+ "outputType" : "ROW<`payment_id` VARCHAR(2147483647), `amount` INT>",
+ "description" : "TableSourceScan(table=[[default_catalog,
default_database, payments]], fields=[payment_id, amount])"
+ }, {
+ "id" : 6,
+ "type" : "stream-exec-exchange_1",
+ "inputProperties" : [ {
+ "requiredDistribution" : {
+ "type" : "HASH",
+ "keys" : [ 0 ]
+ },
+ "damBehavior" : "PIPELINED",
+ "priority" : 0
+ } ],
+ "outputType" : "ROW<`payment_id` VARCHAR(2147483647), `amount` INT>",
+ "description" : "Exchange(distribution=[hash[payment_id]])"
+ }, {
+ "id" : 7,
+ "type" : "stream-exec-process-table-function_1",
+ "inputProperties" : [ {
+ "requiredDistribution" : {
+ "type" : "UNKNOWN"
+ },
+ "damBehavior" : "PIPELINED",
+ "priority" : 0
+ } ],
+ "outputType" : "ROW<`payment_id` VARCHAR(2147483647), `amount` INT>",
+ "description" : "ProcessTableFunction(invocation=[DEDUPLICATE(TABLE(#0)
PARTITION BY($0), DEFAULT(), DEFAULT(), DEFAULT(), DEFAULT(), DEFAULT(),
DEFAULT())], uid=[DEDUPLICATE], select=[payment_id,amount],
rowType=[RecordType(VARCHAR(2147483647) payment_id, INTEGER amount)])",
+ "uid" : "DEDUPLICATE",
+ "functionCall" : {
+ "kind" : "CALL",
+ "internalName" : "$DEDUPLICATE$1",
+ "operands" : [ {
+ "kind" : "TABLE_ARG_CALL",
+ "inputIndex" : 0,
+ "partitionKeys" : [ 0 ],
+ "type" : "ROW<`payment_id` VARCHAR(2147483647), `amount` INT> NOT NULL"
+ }, {
+ "kind" : "CALL",
+ "syntax" : "SPECIAL",
+ "internalName" : "$DEFAULT$1",
+ "type" : "VARCHAR(2147483647)"
+ }, {
+ "kind" : "CALL",
+ "syntax" : "SPECIAL",
+ "internalName" : "$DEFAULT$1",
+ "type" : "DESCRIPTOR"
+ }, {
+ "kind" : "CALL",
+ "syntax" : "SPECIAL",
+ "internalName" : "$DEFAULT$1",
+ "type" : "INTERVAL SECOND(6)"
+ }, {
+ "kind" : "CALL",
+ "syntax" : "SPECIAL",
+ "internalName" : "$DEFAULT$1",
+ "type" : "BOOLEAN"
+ }, {
+ "kind" : "CALL",
+ "syntax" : "SPECIAL",
+ "internalName" : "$DEFAULT$1",
+ "type" : "DESCRIPTOR"
+ }, {
+ "kind" : "CALL",
+ "syntax" : "SPECIAL",
+ "internalName" : "$DEFAULT$1",
+ "type" : "VARCHAR(2147483647)"
+ } ],
+ "type" : "ROW<`payment_id` VARCHAR(2147483647), `amount` INT> NOT NULL"
+ },
+ "inputChangelogModes" : [ [ "INSERT" ] ],
+ "outputChangelogMode" : [ "INSERT", "UPDATE_AFTER" ],
+ "inputUpsertKeys" : [ [ ] ]
Review Comment:
can we avoid empty collections being serialized?
##########
flink-table/flink-table-planner/src/test/resources/restore-tests/stream-exec-process-table-function_1/deduplicate-sequence-by-restore/plan/deduplicate-sequence-by-restore.json:
##########
@@ -0,0 +1,168 @@
+{
+ "flinkVersion" : "2.5",
+ "nodes" : [ {
+ "id" : 9,
+ "type" : "stream-exec-table-source-scan_2",
+ "scanTableSource" : {
+ "table" : {
+ "identifier" :
"`default_catalog`.`default_database`.`customer_changes`",
+ "resolvedTable" : {
+ "schema" : {
+ "columns" : [ {
+ "name" : "customer_id",
+ "dataType" : "VARCHAR(2147483647)"
+ }, {
+ "name" : "city",
+ "dataType" : "VARCHAR(2147483647)"
+ }, {
+ "name" : "lsn",
+ "dataType" : "BIGINT"
+ } ]
+ }
+ }
+ }
+ },
+ "outputType" : "ROW<`customer_id` VARCHAR(2147483647), `city`
VARCHAR(2147483647), `lsn` BIGINT>",
+ "description" : "TableSourceScan(table=[[default_catalog,
default_database, customer_changes]], fields=[customer_id, city, lsn])"
+ }, {
+ "id" : 10,
+ "type" : "stream-exec-exchange_1",
+ "inputProperties" : [ {
+ "requiredDistribution" : {
+ "type" : "HASH",
+ "keys" : [ 0 ]
+ },
+ "damBehavior" : "PIPELINED",
+ "priority" : 0
+ } ],
+ "outputType" : "ROW<`customer_id` VARCHAR(2147483647), `city`
VARCHAR(2147483647), `lsn` BIGINT>",
+ "description" : "Exchange(distribution=[hash[customer_id]])"
+ }, {
+ "id" : 11,
+ "type" : "stream-exec-process-table-function_1",
+ "inputProperties" : [ {
+ "requiredDistribution" : {
+ "type" : "UNKNOWN"
+ },
+ "damBehavior" : "PIPELINED",
+ "priority" : 0
+ } ],
+ "outputType" : "ROW<`customer_id` VARCHAR(2147483647), `city`
VARCHAR(2147483647), `lsn` BIGINT>",
+ "description" : "ProcessTableFunction(invocation=[DEDUPLICATE(TABLE(#0)
PARTITION BY($0), _UTF-16LE'first', DESCRIPTOR(_UTF-16LE'lsn'), DEFAULT(),
DEFAULT(), DEFAULT(), DEFAULT())], uid=[DEDUPLICATE],
select=[customer_id,city,lsn], rowType=[RecordType(VARCHAR(2147483647)
customer_id, VARCHAR(2147483647) city, BIGINT lsn)])",
+ "uid" : "DEDUPLICATE",
+ "functionCall" : {
+ "kind" : "CALL",
+ "internalName" : "$DEDUPLICATE$1",
+ "operands" : [ {
+ "kind" : "TABLE_ARG_CALL",
+ "inputIndex" : 0,
+ "partitionKeys" : [ 0 ],
+ "type" : "ROW<`customer_id` VARCHAR(2147483647), `city`
VARCHAR(2147483647), `lsn` BIGINT> NOT NULL"
+ }, {
+ "kind" : "LITERAL",
+ "value" : "first",
+ "type" : "CHAR(5) NOT NULL"
+ }, {
+ "kind" : "CALL",
+ "internalName" : "$DESCRIPTOR$1",
+ "operands" : [ {
+ "kind" : "LITERAL",
+ "value" : "lsn",
+ "type" : "CHAR(3) NOT NULL"
+ } ],
+ "type" : "DESCRIPTOR NOT NULL"
+ }, {
+ "kind" : "CALL",
+ "syntax" : "SPECIAL",
+ "internalName" : "$DEFAULT$1",
+ "type" : "INTERVAL SECOND(6)"
+ }, {
+ "kind" : "CALL",
+ "syntax" : "SPECIAL",
+ "internalName" : "$DEFAULT$1",
+ "type" : "BOOLEAN"
+ }, {
+ "kind" : "CALL",
+ "syntax" : "SPECIAL",
+ "internalName" : "$DEFAULT$1",
+ "type" : "DESCRIPTOR"
+ }, {
+ "kind" : "CALL",
+ "syntax" : "SPECIAL",
+ "internalName" : "$DEFAULT$1",
+ "type" : "VARCHAR(2147483647)"
+ } ],
+ "type" : "ROW<`customer_id` VARCHAR(2147483647), `city`
VARCHAR(2147483647), `lsn` BIGINT> NOT NULL"
+ },
+ "inputChangelogModes" : [ [ "INSERT" ] ],
+ "outputChangelogMode" : [ "INSERT", "UPDATE_AFTER" ],
+ "inputUpsertKeys" : [ [ ] ]
Review Comment:
same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]