Admaing opened a new pull request, #29984: URL: https://github.com/apache/flink/pull/29984
## What is the purpose of the change With `table.optimizer.delta-join-strategy = FORCE`, a plan that still contains a regular join fails with a message that only dumps the whole plan: ``` The current sql doesn't support to do delta join optimization. The plan is: ...hundreds of lines... ``` Nothing in the message says *which* join could not be converted, so the user has to scan the plan to find it — impractical for a large plan. `DeltaJoinFinder` already walks every join and knows which ones stayed regular, but it only kept a boolean. This collects those nodes and prints them, using the same digest rendering as the plan, before the plan itself. It also removes the `TODO FLINK-37954` that asked for exactly this. ## Brief change log - `StreamPhysicalDeltaJoinForceValidator`: keep the regular joins found by `DeltaJoinFinder` and list them in the `ValidationException` message ahead of the plan. ## Verifying this change - `DeltaJoinTest#testDeltaJoinStrategyWithForce2` now also asserts the new sentence and that the offending join is named. Verified red without the change: the message contains the plan but not the join list. - `./mvnw -pl flink-table/flink-table-planner clean test -Dtest=DeltaJoinTest` — 82 tests pass, with `spotless-check` and `checkstyle`. ## Does this pull request potentially affect one of the following parts - Dependencies: no - The public API, i.e. any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths: no - Anything that affects deployment or recovery: no ## Documentation - Does this pull request introduce a new feature? No, it improves an error message only. --- **AI Disclosure** Prepared with AI assistance (DeepSeek Harness), which drafted the change and the test assertion. I reviewed the diff and ran the commands above locally, including the red run; the direction and the final patch are my own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
