Timm0 commented on code in PR #29929:
URL: https://github.com/apache/flink/pull/29929#discussion_r4598901149


##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/api/internal/TableEnvironmentImpl.java:
##########
@@ -886,6 +887,29 @@ public boolean dropTemporaryModel(String path) {
         }
     }
 
+    @Override
+    public boolean dropMaterializedTable(String path) {
+        return dropMaterializedTable(path, true);
+    }
+
+    @Override
+    public boolean dropMaterializedTable(String path, boolean 
ignoreIfNotExists) {
+        Preconditions.checkNotNull(path, "Path must not be null.");
+        final ObjectIdentifier identifier = getObjectIdentifierFromPath(path);
+        if (ignoreIfNotExists && !isPermanentMaterializedTable(identifier)) {
+            return false;
+        }
+        executeInternal(new DropMaterializedTableOperation(identifier, 
ignoreIfNotExists));

Review Comment:
   I opened this ticket https://issues.apache.org/jira/browse/FLINK-41528 and 
will do it as a followup.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to