poorbarcode commented on PR #132:
URL: 
https://github.com/apache/flink-connector-pulsar/pull/132#issuecomment-6947744365

   @ferenc-csaky I missed point 1 in my last reply. I fixed the 
message-property collision in 
[915f307](https://github.com/apache/flink-connector-pulsar/commit/915f30739b327266232e6a99b3535668e0eeaa85).
 The committer reads the broker’s transaction flags directly from the HTTP 
response headers. It never consults the decoded message properties, including 
properties on individual records in a batch.
   
   The regression test supplies conflicting producer properties alongside the 
broker headers. When the broker reports an open transaction, the lookup returns 
`UNCOMMITTED` even with producer properties setting 
`X-Pulsar-txn-uncommitted=false` and `X-Pulsar-txn-aborted=true`. Missing or 
malformed broker headers cause the lookup to fail. [Regression 
test](https://github.com/apache/flink-connector-pulsar/blob/915f30739b327266232e6a99b3535668e0eeaa85/flink-connector-pulsar/src/test/java/org/apache/flink/connector/pulsar/sink/committer/PulsarTransactionAdminTest.java#L77-L91)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to