Martijn Visser created FLINK-41538:
--------------------------------------

             Summary: Ship the licences and notices of the third-party code 
inside bundled Netty
                 Key: FLINK-41538
                 URL: https://issues.apache.org/jira/browse/FLINK-41538
             Project: Flink
          Issue Type: Bug
          Components: Build System
    Affects Versions: 1.20.5, 2.2.1, 2.3.0
            Reporter: Martijn Visser
            Assignee: Martijn Visser
             Fix For: 2.2.2, 1.20.6, 2.3.1, 2.4.0


Several Flink jars bundle a shaded copy of Netty. Netty contains code from 
other projects under MIT, BSD and public domain terms (Webbit, SLF4J, jbzip2, 
libdivsufsort, jfastlz, Protocol Buffers, two HPACK ports, Robert Harder's 
Base64, JSR-166), and Apache-licensed code whose attribution is in Netty's 
NOTICE (Apache Harmony, JCTools, Twitter's HPACK). Some jars also ship Netty's 
native libraries, which contain BoringSSL or Apple's dnsinfo.h (APSL-2.0).

Compiling drops the source headers, so the jar has to ship the licence texts 
itself. The MIT and BSD licences require their notice in all copies, binaries 
included. For public domain code, https://www.apache.org/legal/resolved.html 
says "You must provide attribution". The relevant parts of Netty's NOTICE, 
including "Copyright 2014 The Netty Project", have to be carried into our 
NOTICE (ALv2 section 4(d), https://infra.apache.org/licensing-howto.html), 
written out in full rather than as pointers (LEGAL-731). dnsinfo.h is only 
allowed under the exception from LEGAL-613, and its licence has to ship with it.

Netty's NOTICE also misses Utf8Validator, which contains MIT code by Bjoern 
Hoehrmann. Netty credits it only in the source header, so the credit is lost 
even in jars that copy Netty's licence folder.

Each jar should carry exactly what it bundles: no entries for Netty's optional 
dependencies or build scripts. The subtasks fix this per module on every 
release line that ships it.



--
This message was sent by Atlassian Jira
(v10.3.26#10030026)

Reply via email to