spuru9 commented on code in PR #30000: URL: https://github.com/apache/flink/pull/30000#discussion_r4611108615
########## flink-python/src/main/resources/META-INF/NOTICE: ########## @@ -54,15 +56,29 @@ The bundled Apache Beam dependencies bundle the following dependencies under the - com.google.api.grpc:proto-google-common-protos:2.9.0 - com.google.code.gson:gson:2.9.0 - com.google.guava:guava:32.1.2-jre -- io.grpc:grpc-auth:1.59.1 -- io.grpc:grpc-core:1.59.1 -- io.grpc:grpc-context:1.59.1 -- io.grpc:grpc-netty:1.59.1 -- io.grpc:grpc-protobuf:1.59.1 -- io.grpc:grpc-stub:1.59.1 -- io.grpc:grpc-testing:1.59.1 -- io.netty:netty-buffer:4.2.17.Final -- io.netty:netty-common:4.2.17.Final +- io.grpc:grpc-auth:1.69.0 +- io.grpc:grpc-core:1.69.0 +- io.grpc:grpc-context:1.69.0 +- io.grpc:grpc-netty:1.69.0 +- io.grpc:grpc-protobuf:1.69.0 +- io.grpc:grpc-stub:1.69.0 +- io.grpc:grpc-testing:1.69.0 +- io.netty:netty-buffer:4.1.110.Final +- io.netty:netty-codec:4.1.110.Final +- io.netty:netty-codec-http:4.1.110.Final +- io.netty:netty-codec-http2:4.1.110.Final +- io.netty:netty-codec-socks:4.1.110.Final +- io.netty:netty-common:4.1.110.Final +- io.netty:netty-handler:4.1.110.Final +- io.netty:netty-handler-proxy:4.1.110.Final +- io.netty:netty-resolver:4.1.110.Final +- io.netty:netty-tcnative-boringssl-static:2.0.65.Final +- io.netty:netty-tcnative-classes:2.0.65.Final +- io.netty:netty-transport:4.1.110.Final +- io.netty:netty-transport-classes-epoll:4.1.110.Final +- io.netty:netty-transport-native-epoll:4.1.110.Final:linux-aarch_64 +- io.netty:netty-transport-native-epoll:4.1.110.Final:linux-x86_64 Review Comment: nit: The NOTICE files and `NoticeParser` put the classifier before the version, so these two get parsed with `linux-aarch_64` as the version. Harmless for the license check, but mind flipping them? ```suggestion - io.netty:netty-transport-native-epoll:linux-aarch_64:4.1.110.Final - io.netty:netty-transport-native-epoll:linux-x86_64:4.1.110.Final ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
