gustavodemorais commented on code in PR #29967:
URL: https://github.com/apache/flink/pull/29967#discussion_r4628281975


##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/functions/ptf/DeduplicateEmitOnceFunction.java:
##########
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.runtime.functions.ptf;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.table.api.DataTypes;
+import org.apache.flink.table.api.dataview.ValueView;
+import org.apache.flink.table.data.RowData;
+import org.apache.flink.table.data.StringData;
+import org.apache.flink.table.data.utils.ProjectedRowData;
+import org.apache.flink.table.functions.FunctionContext;
+import org.apache.flink.table.functions.SpecializedFunction.SpecializedContext;
+import org.apache.flink.types.ColumnList;
+import org.apache.flink.types.RowKind;
+
+import javax.annotation.Nullable;
+
+import java.util.Map;
+
+/**
+ * {@link Deduplicate} with {@code keep => 'first'} and no {@code 
sequence_by}: no later record can
+ * replace the first one, so only whether the key has emitted is kept in the 
{@code seen} state.
+ */
+@Internal
+public class DeduplicateEmitOnceFunction extends DeduplicateFunctionBase {
+
+    private static final long serialVersionUID = 1L;
+
+    private transient ProjectedRowData projectedOutput;
+
+    DeduplicateEmitOnceFunction(final SpecializedContext context) {
+        super(

Review Comment:
   This is hard to read for what it declares: one boolean per key that expires 
after `state_ttl`. Could we add a small generic helper, e.g. in 
`BuiltInProcessTableFunction`, since every stateful built-in PTF needs "a value 
state of type X with the TTL from an argument"? Something like `super(context, 
valueState("emitted", DataTypes.BOOLEAN().notNull(), ARG_STATE_TTL))`. Also, 
the state name ends up in savepoints, so a constant with a name that says what 
it stores (e.g. `emitted`) would help.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to