Github user wangzhijiang999 commented on the issue:
https://github.com/apache/flink/pull/3151
@tillrohrmann , I have submitted the updates that may cover your
suggestions.
There are still two issues that I am not confirmed.
First, for heartbeat interval and timeout default values in
**ConfigConstants**, they are not invalid currently and you can modify it with
your professional experience.
Second, the introduction of **ScheduledExecutorService** in **RPCService**,
my initial idea is trying to use the existing scheduler in **RPCService**, but
it can not be got from **AkkaRPCService** implementation. Another way is to
replace the current **ScheduledExecutorService** parameter with **RPCService**
in construction of **HeartbeatManagerSenderImpl**, and the **RPCService** can
also schedule the heartbeat request. But the return value of
**scheduleRunnable** method in **RPCService** is conflict with that in
**HeartbeatManagerSenderImpl**. So I just bring another single thread pool in
**RPCService** for use currently. Maybe the number of threads in pool can refer
to number of cpu cores.
Maybe there are still something to be polished, and I am willing for
further modifications by your comments.
BTW, the heartbeat interaction between TM and RM will be submitted in
another PR after this confirmation because of some common points.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
