manner commented on code in PR #30051:
URL: https://github.com/apache/flink/pull/30051#discussion_r4645344294
##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/runtime/functions/XmlToVariantParserTest.java:
##########
@@ -338,6 +338,25 @@ Stream<Arguments> typedValues() {
"9999-12-31T23:59:59.999999Z",
Variant.Type.TIMESTAMP_LTZ,
Instant.parse("9999-12-31T23:59:59.999999Z")),
+ // First value of the nanosecond range. The epoch second
times 10^9 overflows a
+ // long in the first second of the range, but the total
nanoseconds fit.
+ arguments(
Review Comment:
Partly yes. I guess the XML parsing tests are not strictly necessary as it's
a Variant fix, but the ticket mentions them, so I pinned down the behaviour of
it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]