spuru9 opened a new pull request, #30060:
URL: https://github.com/apache/flink/pull/30060

   ## What is the purpose of the change
   
   Since FLINK-38311 (Flink 2.2.0), `CatalogPropertiesUtil#deserializeOptions` 
drops every key that starts with `schema` instead of only Flink's own 
`schema.<...>` entries. A catalog that persists tables via 
`ResolvedCatalogTable#toProperties` and reads them back with 
`CatalogTable.fromProperties` therefore loses options such as `schema-name`, 
which the Flink CDC Postgres, Oracle and Db2 sources require. Such a table can 
be created but fails on its first query with `Missing required options are: 
schema-name`.
   
   ## Brief change log
   
     - Exclude only keys starting with `schema.` (`SCHEMA + SEPARATOR`) when 
deserializing options, as before FLINK-38311 and as the `distribution.`, 
`connection.` and `partition.keys.` checks next to it already do. Every key 
Flink writes for the schema is built with `compoundKey(SCHEMA, ...)`, so no 
Flink-written key is affected.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - Added 
`CatalogPropertiesUtilTest#testCatalogTableSerdeKeepsOptionsStartingWithSchema`:
 a table with the options `schema-name` and `schemaless` keeps them through 
`serializeCatalogTable` → `deserializeCatalogTable`. Without the fix it fails 
with `expected: {"connector"="test", "schema-name"="public", 
"schemaless"="true"} but was: {"connector"="test"}`.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Claude Opus 5.5)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to