snuyanzin opened a new pull request, #30063:
URL: https://github.com/apache/flink/pull/30063

   ## What is the purpose of the change
   
   The idea is to decrease amount of reads per one 4-byte unsigned value read
   
   ## Brief change log
   
   variant
   
   ## Verifying this change
   
   existing tests + added test for some edge cases
   
   also measurements for query (`SELECT CAST(v AS ARRAY<STRING>) AS a FROM t`)
   before
   ```
   Benchmark                                             (elementCount)   Mode  
Cnt    Score    Error   Units
   SqlVariantLongStringArrayBenchmark.castToArray                    10  thrpt  
  4  802.398 ± 76.968  ops/ms
   SqlVariantLongStringArrayBenchmark.castToArray                   100  thrpt  
  4  114.479 ± 16.813  ops/ms
   SqlVariantLongStringArrayBenchmark.castToArray                  1000  thrpt  
  4   12.151 ±  0.124  ops/ms
   ```
   after
   ```
   Benchmark                                             (elementCount)   Mode  
Cnt     Score     Error   Units
   SqlVariantLongStringArrayBenchmark.castToArray                    10  thrpt  
  4  1413.743 ± 252.759  ops/ms
   SqlVariantLongStringArrayBenchmark.castToArray                   100  thrpt  
  4   246.556 ±   9.720  ops/ms
   SqlVariantLongStringArrayBenchmark.castToArray                  1000  thrpt  
  4    27.815 ±   0.868  ops/ms
   
   ```
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): ( no)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
     - The serializers: (no)
     - The runtime per-record code paths (performance sensitive): (yes)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? (not applicable)
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   <!--
   If generative AI tooling has been used in the process of authoring this PR, 
please
   change the checkbox below to `[X]` and replace the placeholder in the 
"Generated-by"
   line with the tool name and version. Otherwise remove the "Generated-by" 
line.
   See the ASF Generative Tooling Guidance for details:
   https://www.apache.org/legal/generative-tooling.html
   
   You are responsible for the quality and correctness of every change in this 
PR
   regardless of the tooling used. Low-effort AI-generated PRs will be closed. 
See
   AGENTS.md for the full guidance.
   -->
   
   - [ ] Yes (please specify the tool below)
   
   Generated-by: [Tool Name and Version]
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to