Efrat19 commented on code in PR #344:
URL: 
https://github.com/apache/flink-connector-kafka/pull/344#discussion_r4659770326


##########
flink-connector-kafka/src/main/java/org/apache/flink/connector/kafka/source/KafkaSourceBuilder.java:
##########
@@ -493,9 +493,9 @@ private void parseAndSetRequiredProperties() {
                     configuredOffsetResetStrategy, 
startingOffsetsInitializer)) {
                 LOG.warn(
                         "Configured {}={} differs from the {} strategy derived 
from the starting "
-                                + "offsets initializer. The source will use 
the initializer for "
-                                + "startup, but Kafka may reset to {} if an 
initialized offset "
-                                + "becomes unavailable.",
+                                + "offsets initializer. Kafka will reset to {} 
if a starting "

Review Comment:
   I'd consider unifying both logs text - maybe in OffsetsInitializerValidator 
/ other static util? to avoid repetition, + calculate the correct fallback 
strategy (wrt 
https://github.com/apache/flink-connector-kafka/pull/344#discussion_r4659719271),
 wdyt?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to