Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3277#discussion_r100708670
--- Diff:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/CommonScan.scala
---
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.plan.nodes
+
+import org.apache.flink.api.common.functions.MapFunction
+import org.apache.flink.api.common.typeinfo.TypeInformation
+import org.apache.flink.api.java.typeutils.RowTypeInfo
+import org.apache.flink.table.api.TableConfig
+import org.apache.flink.table.codegen.CodeGenerator
+import org.apache.flink.table.runtime.MapRunner
+import org.apache.flink.types.Row
+
+/**
+ * Common class for batch and stream scans.
+ */
+trait CommonScan {
+
+ /**
+ * We check if the input type is exactly the same as the internal row
type.
+ * A conversion is necessary if types differ or object have to be
unboxed
+ * (i.e. Date, Time, Timestamp need to be converted into their
primitive equivalents).
+ */
+ private[flink] def needsConversion(
+ externalTypeInfo: TypeInformation[Any],
+ internalTypeInfo: TypeInformation[Row])
+ : Boolean = {
+
+ if (externalTypeInfo == internalTypeInfo) {
+ val rowTypeInfo = externalTypeInfo.asInstanceOf[RowTypeInfo]
+ var containsBoxedTypes = false
+ // TODO enable these lines for FLINK-5429
--- End diff --
We should either address FLINK-5429 in this PR or remove the related code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
