Github user rmetzger commented on a diff in the pull request:
https://github.com/apache/flink/pull/3298#discussion_r100978305
--- Diff: flink-dist/src/main/flink-bin/bin/stop-cluster.sh ---
@@ -25,14 +25,30 @@ bin=`cd "$bin"; pwd`
# Stop TaskManager instance(s) using pdsh (Parallel Distributed Shell)
when available
readSlaves
-command -v pdsh >/dev/null 2>&1
-if [[ $? -ne 0 ]]; then
+# all-local setup?
+all_localhost=1
+for slave in ${SLAVES[@]}; do
+ if [[ "$slave" != "localhost" ]]; then
+ all_localhost=0
+ break
+ fi
+done
--- End diff --
I think we should put the all localhost check into a method (maybe into the
config.sh) to avoid duplicate code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
