[ 
https://issues.apache.org/jira/browse/FLINK-5624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15866737#comment-15866737
 ] 

ASF GitHub Bot commented on FLINK-5624:
---------------------------------------

Github user haohui commented on the issue:

    https://github.com/apache/flink/pull/3252
  
    Discussed with @fhueske offline. Thanks a lot for the comments. The V4 PR 
implements the following:
    
    * Rebased on top of #3101 
    * `LogicalWindowAggregateRule` implements `RelOptRule` instead of the 
`ConvertRule`.
    * Instead of adding a new field in `LogicalWindowAggregate`, the 
implementation now transforms the original `LogicalAggregate(LogicalProject())` 
expression to `LogicalProject(LogicalWindowAggregate(LogicalProject(...)))`. 
The outermost projection ensures that the operators have the same row types 
before and after the transformation.
    
    Please take another look.


> Support tumbling window on streaming tables in the SQL API
> ----------------------------------------------------------
>
>                 Key: FLINK-5624
>                 URL: https://issues.apache.org/jira/browse/FLINK-5624
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>            Reporter: Haohui Mai
>            Assignee: Haohui Mai
>
> This is a follow up of FLINK-4691.
> FLINK-4691 adds supports for group-windows for streaming tables. This jira 
> proposes to expose the functionality in the SQL layer via the {{GROUP BY}} 
> clauses, as described in 
> http://calcite.apache.org/docs/stream.html#tumbling-windows.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to