[ 
https://issues.apache.org/jira/browse/FLINK-5814?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15869530#comment-15869530
 ] 

ASF GitHub Bot commented on FLINK-5814:
---------------------------------------

GitHub user NicoK opened a pull request:

    https://github.com/apache/flink/pull/3331

    [FLINK-5814] fix packaging flink-dist in unclean source directory

    If `<flink-dir>/build-target` already existed, running `mvn package` for
    flink-dist would create a symbolic link inside `<flink-dir>/build-target`
    instead of replacing that symlink. This commit fixes this behaviour of `ln 
-sf`
    by adding the `--no-dereference` parameter.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-5814

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/3331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3331
    
----
commit 032209e43c5f6b9641053d3317561646ba0b4f7f
Author: Nico Kruber <n...@data-artisans.com>
Date:   2017-02-15T14:50:45Z

    [FLINK-5814] fix packaging flink-dist in unclean source directory
    
    If "<flink-dir>/build-target" already existed, running 'mvn package' for
    flink-dist would create a symbolic link inside "<flink-dir>/build-target"
    instead of replacing that symlink. This commit fixes this behaviour of 'ln 
-sf'
    by adding the --no-dereference parameter.

----


> flink-dist creates wrong symlink when not used with cleaned before
> ------------------------------------------------------------------
>
>                 Key: FLINK-5814
>                 URL: https://issues.apache.org/jira/browse/FLINK-5814
>             Project: Flink
>          Issue Type: Bug
>          Components: Build System
>    Affects Versions: 1.2.0
>            Reporter: Nico Kruber
>            Assignee: Nico Kruber
>            Priority: Minor
>
> If {{<flink-dir>/build-target}} already exists, 'mvn package' for flink-dist  
> will create a symbolic link *inside* {{<flink-dir>/build-target}} instead of 
> replacing that symlink. This is due to the behaviour of {{ln \-sf}} for 
> target links that point to directories and may be solved by adding the 
> {{--no-dereference}} parameter.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to