GitHub user uce opened a pull request:
https://github.com/apache/flink/pull/3345
[FLINK-5763] [checkpoints] Minor meta data refactorings
This PR groups some refactorings I did as part of FLINK-5763 into a
separate PR.
1) Acknowledges with explicit ID and `CheckpointMetrics`
Instead of acknowledging checkpoints with `CheckpointMetaData`, I reduce
this to what's needed: the checkpoint ID and the `CheckpointMetrics`.
2) Move `CheckpointMetrics` out of the `CheckpointMetaData`
`CheckpointMetaData` was overloaded with the metrics that are actually
only needed for the acknowledgement. `CheckpointMetaData` should in my opinion
only contain fixed properties that are relevant for the checkpoint.
3) Make `CheckpointProperties` isSavepoint check non-static
There was no good reason that this check was a static helper method. We
should simply call `props.isSavepoint()`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/uce/flink selfcontained_refactorings
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3345
----
commit 64e1f8892597dd26489774fe494fd7b211d789a9
Author: Ufuk Celebi <[email protected]>
Date: 2017-02-15T16:52:40Z
[FLINK-5763] [checkpoints] Acknowledge with explicit ID and
CheckpointMetrics
Instead of acknowledging checkpoints with the CheckpointMetaData make
the acknowledgement explicit by ID and CheckpointMetrics. The rest is
not needed.
commit 0b8fa02a150ae6d5891e04d1fce6de748a283aaf
Author: Ufuk Celebi <[email protected]>
Date: 2017-02-15T17:16:44Z
[FLINK-5763] [checkpoints] Move CheckpointMetrics out of CheckpointMetaData
commit d023159d0fef1da24373d7880e11d0a36afbd7ef
Author: Ufuk Celebi <[email protected]>
Date: 2017-02-16T15:52:32Z
[FLINK-5763] [checkpoints] Add isSavepoint() to CheckpointProperties
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
