Github user StephanEwen commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3295#discussion_r101827724
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/concurrent/FutureUtils.java
 ---
    @@ -88,4 +100,104 @@ public RetryException(Throwable cause) {
                        super(cause);
                }
        }
    +
    +   // 
------------------------------------------------------------------------
    +   //  composing futures
    +   // 
------------------------------------------------------------------------
    +
    +   /**
    +    * Creates a future that is complete once multiple other futures 
completed. 
    +    * The ConjunctFuture fails (completes exceptionally) once one of the 
Futures in the
    +    * conjunction fails.
    +    *
    +    * <p>The ConjunctFuture gives access to how many Futures in the 
conjunction have already
    +    * completed successfully, via {@link 
ConjunctFuture#getNumFuturesCompleted()}. 
    +    * 
    +    * @param futures The futures that make up the conjunction. No null 
entries are allowed.
    +    * @return The ConjunctFuture that completes once all given futures are 
complete (or one fails).
    +    */
    +   public static ConjunctFuture combineAll(Collection<? extends Future<?>> 
futures) {
    +           checkNotNull(futures, "futures");
    +           checkArgument(!futures.isEmpty(), "futures is empty");
    --- End diff --
    
    Yes, will change that...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to