[
https://issues.apache.org/jira/browse/FLINK-4460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872353#comment-15872353
]
ASF GitHub Bot commented on FLINK-4460:
---------------------------------------
Github user chenqin commented on the issue:
https://github.com/apache/flink/pull/2982
@aljoscha Looks good to me 👍
I briefly looked at your git branch, a minor comment would be adding
comments to `sideOutputLateData` so user get better idea when they opt-in to
late arriving event stream.
Initial late arriving event is decided by comparing watermark & eventTime,
do you think there is a need to allow user pass a kinda `Evaluator` and enable
user sideOutput any kind of sideOutputs?
`window.sideOutput(OutputTag<IN>, Evaluator)`
`interface Evaluator{ MergedWindows, key, watermark}`
- Regarding `split` `select`, I think there is a chance of consolidate
select and build upon `OutputTag`, but might be out of this PR's scope.
- Regarding to `WindowStream`, I am a bit confused to figure out if I use
`allowedlateness` and `sideOutputLateData` at same time.
Thanks,
Chen
> Side Outputs in Flink
> ---------------------
>
> Key: FLINK-4460
> URL: https://issues.apache.org/jira/browse/FLINK-4460
> Project: Flink
> Issue Type: New Feature
> Components: Core, DataStream API
> Affects Versions: 1.2.0, 1.1.3
> Reporter: Chen Qin
> Assignee: Chen Qin
> Labels: latearrivingevents, sideoutput
>
> https://docs.google.com/document/d/1vg1gpR8JL4dM07Yu4NyerQhhVvBlde5qdqnuJv4LcV4/edit?usp=sharing
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
