Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/3348#discussion_r101992784
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/taskmanager/Task.java ---
@@ -385,6 +388,20 @@ public Task(
++counter;
}
+ // register detailed network metrics, if configured
+ if
(tmConfig.getBoolean(ConfigConstants.NETWORK_DETAILED_METRICS_KEY, false)) {
+ // output metrics
--- End diff --
Regarding the MetricGroup struccture/naming i would suggest the following:
```
MetricGroup networkGroup = metricGroup.addGroup("Network"); // this is for
consistency purposes
MetricGroup inputGroup = networkGroup.addGroup("Input"); // this is optional
MetricGroup outputGroup = networkGroup.addGroup("Output"); // this is
optional
for (...) {
X.registerQueueLengthMetrics(metricGroup.addGroup(i), <gate/partition>);
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
