[
https://issues.apache.org/jira/browse/FLINK-4856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874579#comment-15874579
]
ASF GitHub Bot commented on FLINK-4856:
---------------------------------------
Github user StefanRRichter commented on a diff in the pull request:
https://github.com/apache/flink/pull/3336#discussion_r101994211
--- Diff:
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapMapState.java
---
@@ -0,0 +1,321 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.runtime.state.heap;
+
+import org.apache.flink.api.common.state.MapState;
+import org.apache.flink.api.common.state.MapStateDescriptor;
+import org.apache.flink.api.common.typeutils.TypeSerializer;
+import org.apache.flink.core.memory.DataOutputViewStreamWrapper;
+import org.apache.flink.runtime.state.KeyGroupRangeAssignment;
+import org.apache.flink.runtime.state.KeyedStateBackend;
+import org.apache.flink.runtime.state.internal.InternalMapState;
+import org.apache.flink.util.Preconditions;
+
+import java.io.ByteArrayOutputStream;
+import java.io.IOException;
+import java.util.HashMap;
+import java.util.Iterator;
+import java.util.Map;
+
+/**
+ * Heap-backed partitioned {@link MapState} that is snapshotted into files.
+ *
+ * @param <K> The type of the key.
+ * @param <N> The type of the namespace.
+ * @param <UK> The type of the keys in the state.
+ * @param <UV> The type of the values in the state.
+ */
+public class HeapMapState<K, N, UK, UV>
+ extends AbstractHeapState<K, N, HashMap<UK, UV>, MapState<UK,
UV>, MapStateDescriptor<UK, UV>>
+ implements InternalMapState<N, UK, UV> {
+
+ /**
+ * Creates a new key/value state for the given hash map of key/value
pairs.
+ *
+ * @param backend The state backend backing that created this state.
+ * @param stateDesc The state identifier for the state. This contains
name
+ * and can create a default state value.
+ * @param stateTable The state tab;e to use in this kev/value state.
May contain initial state.
+ */
+ public HeapMapState(KeyedStateBackend<K> backend,
+ MapStateDescriptor<UK, UV> stateDesc,
+ StateTable<K, N, HashMap<UK, UV>> stateTable,
+ TypeSerializer<K> keySerializer,
+ TypeSerializer<N> namespaceSerializer) {
+ super(backend, stateDesc, stateTable, keySerializer,
namespaceSerializer);
+ }
+
+ @Override
+ public UV get(UK userKey) throws IOException {
+ Preconditions.checkState(currentNamespace != null, "No
namespace set.");
+ Preconditions.checkState(backend.getCurrentKey() != null, "No
key set.");
+
+ Map<N, Map<K, HashMap<UK, UV>>> namespaceMap =
stateTable.get(backend.getCurrentKeyGroupIndex());
+ if (namespaceMap == null) {
+ return null;
+ }
+
+ Map<K, HashMap<UK, UV>> keyedMap =
namespaceMap.get(currentNamespace);
+ if (keyedMap == null) {
+ return null;
+ }
+
+ HashMap<UK, UV> userMap =
keyedMap.get(backend.<K>getCurrentKey());
+ if (userMap == null) {
+ return null;
+ }
+
+ return userMap.get(userKey);
+ }
+
+ @Override
+ public void put(UK userKey, UV userValue) throws IOException {
+ Preconditions.checkState(currentNamespace != null, "No
namespace set.");
+ Preconditions.checkState(backend.getCurrentKey() != null, "No
key set.");
+
+ Map<N, Map<K, HashMap<UK, UV>>> namespaceMap =
stateTable.get(backend.getCurrentKeyGroupIndex());
+ if (namespaceMap == null) {
+ namespaceMap = createNewMap();
+ stateTable.set(backend.getCurrentKeyGroupIndex(),
namespaceMap);
+ }
+
+ Map<K, HashMap<UK, UV>> keyedMap =
namespaceMap.get(currentNamespace);
+ if (keyedMap == null) {
+ keyedMap = createNewMap();
+ namespaceMap.put(currentNamespace, keyedMap);
+ }
+
+ HashMap<UK, UV> userMap = keyedMap.get(backend.getCurrentKey());
+ if (userMap == null) {
+ userMap = new HashMap<>();
+ keyedMap.put(backend.getCurrentKey(), userMap);
+ }
+
+ userMap.put(userKey, userValue);
+ }
+
+ @Override
+ public void remove(UK userKey) throws IOException {
+ Preconditions.checkState(currentNamespace != null, "No
namespace set.");
+ Preconditions.checkState(backend.getCurrentKey() != null, "No
key set.");
+
+ Map<N, Map<K, HashMap<UK, UV>>> namespaceMap =
stateTable.get(backend.getCurrentKeyGroupIndex());
+ if (namespaceMap == null) {
+ return;
+ }
+
+ Map<K, HashMap<UK, UV>> keyedMap =
namespaceMap.get(currentNamespace);
+ if (keyedMap == null) {
+ return;
+ }
+
+ HashMap<UK, UV> userMap = keyedMap.get(backend.getCurrentKey());
+ if (userMap == null) {
+ return;
+ }
+
+ userMap.remove(userKey);
+
+ if (userMap.isEmpty()) {
+ clear();
+ }
+ }
+
+ @Override
+ public boolean contains(UK userKey) throws IOException {
+ Preconditions.checkState(currentNamespace != null, "No
namespace set.");
+ Preconditions.checkState(backend.getCurrentKey() != null, "No
key set.");
+
+ Map<N, Map<K, HashMap<UK, UV>>> namespaceMap =
stateTable.get(backend.getCurrentKeyGroupIndex());
+ if (namespaceMap == null) {
+ return false;
+ }
+
+ Map<K, HashMap<UK, UV>> keyedMap =
namespaceMap.get(currentNamespace);
+ if (keyedMap == null) {
+ return false;
+ }
+
+ HashMap<UK, UV> userMap =
keyedMap.get(backend.<K>getCurrentKey());
+
+ return userMap != null && userMap.containsKey(userKey);
+ }
+
+ @Override
+ public int size() throws IOException {
+ Preconditions.checkState(currentNamespace != null, "No
namespace set.");
+ Preconditions.checkState(backend.getCurrentKey() != null, "No
key set.");
+
+ Map<N, Map<K, HashMap<UK, UV>>> namespaceMap =
stateTable.get(backend.getCurrentKeyGroupIndex());
+ if (namespaceMap == null) {
+ return 0;
+ }
+
+ Map<K, HashMap<UK, UV>> keyedMap =
namespaceMap.get(currentNamespace);
+ if (keyedMap == null) {
+ return 0;
+ }
+
+ HashMap<UK, UV> userMap =
keyedMap.get(backend.<K>getCurrentKey());
+
+ return userMap == null ? 0 : userMap.size();
+ }
+
+ @Override
+ public Iterable<UK> keys() {
+ Preconditions.checkState(currentNamespace != null, "No
namespace set.");
+ Preconditions.checkState(backend.getCurrentKey() != null, "No
key set.");
+
+ Map<N, Map<K, HashMap<UK, UV>>> namespaceMap =
stateTable.get(backend.getCurrentKeyGroupIndex());
+ if (namespaceMap == null) {
+ return null;
+ }
+
+ Map<K, HashMap<UK, UV>> keyedMap =
namespaceMap.get(currentNamespace);
+ if (keyedMap == null) {
+ return null;
+ }
+
+ HashMap<UK, UV> userMap =
keyedMap.get(backend.<K>getCurrentKey());
+
+ return userMap == null ? null : userMap.keySet();
+ }
+
+ @Override
+ public Iterable<UV> values() {
+ Preconditions.checkState(currentNamespace != null, "No
namespace set.");
+ Preconditions.checkState(backend.getCurrentKey() != null, "No
key set.");
+
+ Map<N, Map<K, HashMap<UK, UV>>> namespaceMap =
stateTable.get(backend.getCurrentKeyGroupIndex());
+ if (namespaceMap == null) {
+ return null;
+ }
+
+ Map<K, HashMap<UK, UV>> keyedMap =
namespaceMap.get(currentNamespace);
+ if (keyedMap == null) {
+ return null;
+ }
+
+ HashMap<UK, UV> userMap =
keyedMap.get(backend.<K>getCurrentKey());
+
+ return userMap == null ? null : userMap.values();
+ }
+
+ @Override
+ public Iterator<Map.Entry<UK, UV>> iterator() {
+ Preconditions.checkState(currentNamespace != null, "No
namespace set.");
+ Preconditions.checkState(backend.getCurrentKey() != null, "No
key set.");
+
+ Map<N, Map<K, HashMap<UK, UV>>> namespaceMap =
stateTable.get(backend.getCurrentKeyGroupIndex());
+ if (namespaceMap == null) {
+ return null;
+ }
+
+ Map<K, HashMap<UK, UV>> keyedMap =
namespaceMap.get(currentNamespace);
+ if (keyedMap == null) {
+ return null;
+ }
+
+ HashMap<UK, UV> userMap =
keyedMap.get(backend.<K>getCurrentKey());
+
+ return userMap == null ? null : userMap.entrySet().iterator();
+ }
+
+ @Override
+ public Iterable<Map.Entry<UK, UV>> get() throws Exception {
+ Preconditions.checkState(currentNamespace != null, "No
namespace set.");
+ Preconditions.checkState(backend.getCurrentKey() != null, "No
key set.");
+
+ Map<N, Map<K, HashMap<UK, UV>>> namespaceMap =
stateTable.get(backend.getCurrentKeyGroupIndex());
+ if (namespaceMap == null) {
+ return null;
+ }
+
+ Map<K, HashMap<UK, UV>> keyedMap =
namespaceMap.get(currentNamespace);
+ if (keyedMap == null) {
+ return null;
+ }
+
+ HashMap<UK, UV> userMap =
keyedMap.get(backend.<K>getCurrentKey());
+
+ return userMap == null ? null : userMap.entrySet();
+ }
+
+ @Override
+ public void add(Map<UK, UV> value) throws Exception {
+ Preconditions.checkState(currentNamespace != null, "No
namespace set.");
+ Preconditions.checkState(backend.getCurrentKey() != null, "No
key set.");
+
+ Map<N, Map<K, HashMap<UK, UV>>> namespaceMap =
stateTable.get(backend.getCurrentKeyGroupIndex());
+ if (namespaceMap == null) {
+ namespaceMap = createNewMap();
+ stateTable.set(backend.getCurrentKeyGroupIndex(),
namespaceMap);
+ }
+
+ Map<K, HashMap<UK, UV>> keyedMap =
namespaceMap.get(currentNamespace);
+ if (keyedMap == null) {
+ keyedMap = createNewMap();
+ namespaceMap.put(currentNamespace, keyedMap);
+ }
+
+ HashMap<UK, UV> userMap = keyedMap.get(backend.getCurrentKey());
+ if (userMap == null) {
+ userMap = new HashMap<>();
+ keyedMap.put(backend.getCurrentKey(), userMap);
+ }
+
+ userMap.putAll(value);
+ }
+
+ @Override
+ public byte[] getSerializedValue(K key, N namespace) throws Exception {
+ Preconditions.checkState(namespace != null, "No namespace
given.");
+ Preconditions.checkState(key != null, "No key given.");
+
+ Map<N, Map<K, HashMap<UK, UV>>> namespaceMap =
stateTable.get(KeyGroupRangeAssignment.assignToKeyGroup(key,
backend.getNumberOfKeyGroups()));
+
+ if (namespaceMap == null) {
+ return null;
+ }
+
+ Map<K, HashMap<UK, UV>> keyedMap =
namespaceMap.get(currentNamespace);
+ if (keyedMap == null) {
+ return null;
+ }
+
+ HashMap<UK, UV> result = keyedMap.get(key);
+ if (result == null) {
+ return null;
+ }
+
+ TypeSerializer<UK> userKeySerializer =
stateDesc.getKeySerializer();
+ TypeSerializer<UV> userValueSerializer =
stateDesc.getValueSerializer();
+
+ ByteArrayOutputStream baos = new ByteArrayOutputStream();
--- End diff --
You could use `ByteArrayOutputStreamWithPos` here. It is basically the same
as `ByteArrayOutputStream`, but can give a position and is not synchronized on
every method.
> Add MapState for keyed streams
> ------------------------------
>
> Key: FLINK-4856
> URL: https://issues.apache.org/jira/browse/FLINK-4856
> Project: Flink
> Issue Type: New Feature
> Components: DataStream API, State Backends, Checkpointing
> Reporter: Xiaogang Shi
> Assignee: Xiaogang Shi
>
> Many states in keyed streams are organized as key-value pairs. Currently,
> these states are implemented by storing the entire map into a ValueState or a
> ListState. The implementation however is very costly because all entries have
> to be serialized/deserialized when updating a single entry. To improve the
> efficiency of these states, MapStates are urgently needed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
