[ 
https://issues.apache.org/jira/browse/FLINK-5795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15874666#comment-15874666
 ] 

ASF GitHub Bot commented on FLINK-5795:
---------------------------------------

Github user wuchong commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3330#discussion_r102037328
  
    --- Diff: 
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/functions/ScalarFunction.scala
 ---
    @@ -58,6 +60,11 @@ abstract class ScalarFunction extends 
UserDefinedFunction {
     
       override def toString: String = getClass.getCanonicalName
     
    +  final def functionIdentifier: String = {
    --- End diff --
    
    The  `UserDefinedFunction` has been declared as an abstract class in the 
newest master when we adding `open` and `close` default implementation. I think 
the `functionIdentifier` can be the same and will not hurt anything.


> Improve “UDTF" to support constructor with parameter.
> -----------------------------------------------------
>
>                 Key: FLINK-5795
>                 URL: https://issues.apache.org/jira/browse/FLINK-5795
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to