[
https://issues.apache.org/jira/browse/FLINK-5836?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875280#comment-15875280
]
ASF GitHub Bot commented on FLINK-5836:
---------------------------------------
GitHub user wenlong88 opened a pull request:
https://github.com/apache/flink/pull/3371
[FLINK-5836] Fix race condition between offer slot and submit task
The solution is the same as what till described in jira: activating the
slots when reserving them on `TaskExecutor` before offering to `JobManager`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wenlong88/flink jira-5836
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3371.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3371
----
commit 35042f29e055a7f83b7c4d79e4c72673711dfd78
Author: wenlong.lwl <[email protected]>
Date: 2017-01-06T08:32:08Z
Fix race condition between offer slot and submit task
----
> Race condition between slot offering and task deployment
> --------------------------------------------------------
>
> Key: FLINK-5836
> URL: https://issues.apache.org/jira/browse/FLINK-5836
> Project: Flink
> Issue Type: Bug
> Components: Distributed Coordination
> Affects Versions: 1.3.0
> Reporter: Till Rohrmann
> Assignee: Wenlong Lyu
> Labels: flip-6
>
> The Flip-6 code has a race condition when offering slots to a {{JobManager}}
> which directly deploys tasks to the offered slots. In such a situation it is
> possible that the deploy call overtakes the acknowledge message for the slot
> offering. As a result, the slots are not marked yet as active and the
> deployment will fail.
> I propose to fix this problem by first activating all offered slots before
> sending the slot offer message to the {{JobManager}}. Consequently, we'll
> deactivate and free slots which haven't been accepted by the {{JobManager}}
> once we've received the offering acknowledge message.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
