Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3366#discussion_r102206279
--- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee
---
@@ -87,3 +87,27 @@ angular.module('flinkApp')
.filter "percentage", ->
(number) -> (number * 100).toFixed(0) + '%'
+
+.filter "parseWatermark", ->
+ (value) ->
+ if value <= -9223372036854776000
+ return 'No Watermark'
+ else
+ return value
+
+.filter "lowWatermark", ->
+ (watermarks, nodeid) ->
+ lowWatermark = "None"
+ if watermarks != null && watermarks[nodeid] &&
watermarks[nodeid].length
+ values = (watermark.value for watermark in watermarks[nodeid])
+ lowWatermark = Math.min.apply(null, values)
+ if lowWatermark <= -9223372036854776000
+ lowWatermark = "No Watermark"
--- End diff --
I think this can be confusing to users, because with the logic below it
sometimes says `No watermark` or `None` depending on whether the metric was
available or not. I think we should stick to one of the two. The comment about
the constant applies here as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
