[
https://issues.apache.org/jira/browse/FLINK-3427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875997#comment-15875997
]
ASF GitHub Bot commented on FLINK-3427:
---------------------------------------
Github user uce commented on a diff in the pull request:
https://github.com/apache/flink/pull/3366#discussion_r102206279
--- Diff: flink-runtime-web/web-dashboard/app/scripts/common/filters.coffee
---
@@ -87,3 +87,27 @@ angular.module('flinkApp')
.filter "percentage", ->
(number) -> (number * 100).toFixed(0) + '%'
+
+.filter "parseWatermark", ->
+ (value) ->
+ if value <= -9223372036854776000
+ return 'No Watermark'
+ else
+ return value
+
+.filter "lowWatermark", ->
+ (watermarks, nodeid) ->
+ lowWatermark = "None"
+ if watermarks != null && watermarks[nodeid] &&
watermarks[nodeid].length
+ values = (watermark.value for watermark in watermarks[nodeid])
+ lowWatermark = Math.min.apply(null, values)
+ if lowWatermark <= -9223372036854776000
+ lowWatermark = "No Watermark"
--- End diff --
I think this can be confusing to users, because with the logic below it
sometimes says `No watermark` or `None` depending on whether the metric was
available or not. I think we should stick to one of the two. The comment about
the constant applies here as well.
> Add watermark monitoring to JobManager web frontend
> ---------------------------------------------------
>
> Key: FLINK-3427
> URL: https://issues.apache.org/jira/browse/FLINK-3427
> Project: Flink
> Issue Type: Improvement
> Components: Streaming, Webfrontend
> Reporter: Robert Metzger
>
> Currently, its quite hard to figure out issues with the watermarks.
> I think we can improve the situation by reporting the following information
> through the metrics system:
> - Report the current low watermark for each operator (this way, you can see
> if one operator is preventing the watermarks to rise)
> - Report the number of events arrived after the low watermark (users can see
> how accurate the watermarks are)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
