[
https://issues.apache.org/jira/browse/FLINK-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15877248#comment-15877248
]
ASF GitHub Bot commented on FLINK-4754:
---------------------------------------
Github user tony810430 commented on the issue:
https://github.com/apache/flink/pull/3374
Hi @StephanEwen thanks for your feedback.
I totally agree your opinion. I will make this setting be configured in
`FlinkConfiguration` and be passed to `CheckpointRecoveryFactory`.
Besides, I have some questions for the following implementations.
- Should the verification of this setting throw exception or make it be the
default value when the setting is set with illegal value like `-1`.
- Where should I verify this setting If we need to throw the exception? I
couldn't find the validation util for `FlinkConfiguration`, so I don't know
where I should place my code.
- Should I remain the setting to provide flexibility for _developers_ or
just make it be the _ops_' responsibility only?
Looking forward to having your opinion. Thank you.
> Make number of retained checkpoints user configurable
> -----------------------------------------------------
>
> Key: FLINK-4754
> URL: https://issues.apache.org/jira/browse/FLINK-4754
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.1.2
> Reporter: Ufuk Celebi
> Assignee: Wei-Che Wei
>
> The number of retained successful checkpoints is fixed to 1. Expose this
> setting via the {{CheckpointConfig}} instead of having it fixed as a static
> field in the {{CheckpointRecoveryFactory}}.
> With the current state of things, this would require to set this value lazily
> in the checkpoint store implementations instead of setting it when creating
> the store.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
