Github user jinmingjian commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3384#discussion_r102435330
  
    --- Diff: 
flink-clients/src/test/java/org/apache/flink/client/program/ClientConnectionTest.java
 ---
    @@ -115,13 +115,13 @@ public void run() {
     
                        try {
                                // wait until the caller is successful, for at 
most the given time
    -                           long now = System.currentTimeMillis();
    -                           long deadline = now + MAX_DELAY;
    +                           long now = System.nanoTime();
    +                           long deadline = now + MAX_DELAY*1000000;
    --- End diff --
    
    agree, although I commonly use 1000_000 in fact:) I planed to use [this 
detailed idea 
style](https://raw.githubusercontent.com/dawidwys/flink/bee981be8aa83225a8e3a736700eae445d79cece/tools/FlinkCodeStyle.xml)
 after digging today's discussions in mail list. Is this OK?:)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to