[
https://issues.apache.org/jira/browse/FLINK-5845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15878220#comment-15878220
]
ASF GitHub Bot commented on FLINK-5845:
---------------------------------------
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3375#discussion_r102462479
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/KeyedCEPPatternOperator.java
---
@@ -40,25 +40,27 @@
public class KeyedCEPPatternOperator<IN, KEY> extends
AbstractKeyedCEPPatternOperator<IN, KEY, Map<String, IN>> {
private static final long serialVersionUID = 5328573789532074581L;
- public KeyedCEPPatternOperator(TypeSerializer<IN> inputSerializer,
boolean isProcessingTime, KeySelector<IN, KEY> keySelector, TypeSerializer<KEY>
keySerializer, NFACompiler.NFAFactory<IN> nfaFactory) {
+ public KeyedCEPPatternOperator(
+ TypeSerializer<IN> inputSerializer,
+ boolean isProcessingTime,
+ KeySelector<IN, KEY> keySelector,
+ TypeSerializer<KEY> keySerializer,
+ NFACompiler.NFAFactory<IN> nfaFactory) {
--- End diff --
double indentation for method declarations is better because then one can
more easily distinguish the parameter list from the body.
> CEP: unify key and non-keyed operators
> --------------------------------------
>
> Key: FLINK-5845
> URL: https://issues.apache.org/jira/browse/FLINK-5845
> Project: Flink
> Issue Type: Sub-task
> Components: CEP
> Affects Versions: 1.3.0
> Reporter: Kostas Kloudas
> Assignee: Kostas Kloudas
> Fix For: 1.3.0
>
>
> Currently the keyed and non-keyed operators in the CEP library have different
> implementations. This issue targets to unify them into one.
> This new implementation will always be applied on a keyed stream, and in the
> case of non-keyed usecases, the input stream will be keyed on a dummy key, as
> done in the case of the {{DataStream.windowAll()}} method, where the input
> stream is keyed using the {{NullByteKeySelector}}.
> This is a first step towards making the CEP operators rescalable.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
