Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/3375#discussion_r102461630
--- Diff:
flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/operator/AbstractKeyedCEPPatternOperator.java
---
@@ -100,27 +119,21 @@ public void open() throws Exception {
if (nfaOperatorState == null) {
nfaOperatorState = getPartitionedState(
- new ValueStateDescriptor<NFA<IN>>(
- NFA_OPERATOR_STATE_NAME,
- new NFA.Serializer<IN>()));
+ new
ValueStateDescriptor<>(NFA_OPERATOR_STATE_NAME, new NFA.Serializer<IN>()));
}
@SuppressWarnings("unchecked,rawtypes")
TypeSerializer<StreamRecord<IN>> streamRecordSerializer =
- (TypeSerializer) new
StreamElementSerializer<>(getInputSerializer());
+ (TypeSerializer) new
StreamElementSerializer<>(getInputSerializer());
if (priorityQueueOperatorState == null) {
priorityQueueOperatorState = getPartitionedState(
- new ValueStateDescriptor<>(
- PRIORIRY_QUEUE_STATE_NAME,
- new PriorityQueueSerializer<>(
-
streamRecordSerializer,
- new
PriorityQueueStreamRecordFactory<IN>())));
+ new
ValueStateDescriptor<>(PRIORITY_QUEUE_STATE_NAME,
+ new
PriorityQueueSerializer<>(streamRecordSerializer, new
PriorityQueueStreamRecordFactory<IN>())));
--- End diff --
If doing reformatting changes then please try to not change a consistent
style. When breaking long parameter lists, imo, every parameter should be on a
separate line and indented identically. This is not the case with
`PRIORITY_QUEUE_STATE_NAME`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
