Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/3377#discussion_r102467283
  
    --- Diff: 
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
 ---
    @@ -855,14 +877,23 @@ private boolean processFail(Throwable t, boolean 
isCallback) {
                        }
     
                        if (current == CANCELING) {
    -                           cancelingComplete();
    +                           cancelingComplete(userAccumulators, metrics);
                                return false;
                        }
     
                        if (transitionState(current, FAILED, t)) {
                                // success (in a manner of speaking)
                                this.failureCause = t;
     
    +                           if (userAccumulators != null) {
    +                                   synchronized (accumulatorLock) {
    +                                           this.userAccumulators = 
userAccumulators;
    +                                   }
    +                           }
    +                           if (metrics != null) {
    +                                   this.ioMetrics = metrics;
    +                           }
    --- End diff --
    
    Can this also be a separate method?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to